Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use direct metric export instead of prometheus scraping #70

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

matthagenbuch
Copy link
Contributor

What is the current behavior?

currently uses prometheus metric self-scraping to export monitoring metrics

What is the new behavior?

export monitoring metrics directly to lightstep

this will resolve metric type mismatch issues resulting from multiple ways of exporting otelcol metrics to internal lightstep projects


Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests(make test) for the changes have been added (for bug fixes / features) and pass
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Lint (make lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@matthagenbuch matthagenbuch marked this pull request as ready for review September 9, 2024 18:14
@matthagenbuch matthagenbuch merged commit b1d27ed into main Sep 9, 2024
3 checks passed
@matthagenbuch matthagenbuch deleted the matth.direct_export branch September 9, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants