LS-58504-cleanup-generaterootmod and CI checks #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update the README 2. update generaterootmod so it programmatically gets the required provider version 3. remove the broken pre-commit-config in favor of `make ready` 4. fix the broken make ready command
adil-sultan
changed the title
gdfast
approved these changes
Jan 29, 2024
| @@ -1,4 +1,4 @@ | |||
| variable "lightstep_project" { | |||
| description = "Name of Cloud Observability project" | |||
| type = string | |||
| } | |||
| } | |||
There was a problem hiding this comment.
This file was inconsistent with the newline at the end so I just added them across the board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
This PR addresses some housekeeping for this repo.
updates
generaterootmodso it programmatically gets the required provider version from a module. This should be safe since dependabot will keep all the modules in sync with the latest provider versionFixes the broken pre-commit by adding a
go.modat the root of the repo and cleaning up the arguments for tflint so it can recursively check subdirectoriesFixes the broken
make readycommand by cleaning up the arguments for tflint so it can recursively check subdirectories with the config defined at the root of the repo.Please confirm the following items:
The checklist below doesn't apply. Instead, you can test this locally by cloning down this branch and running:
make readypre-commit run --all-filesor make some changes and try to commit themPR checklist