Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pie chart to chart display-type options #214

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Add Pie chart to chart display-type options #214

merged 4 commits into from
Mar 4, 2024

Conversation

erik-snow
Copy link
Contributor

With the newly released pie charts, add pie as a valid display-type

@erik-snow erik-snow requested review from bcronin and ahiseley March 1, 2024 00:23
bcronin
bcronin reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@bcronin bcronin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the unit tests are failing

@erik-snow
Copy link
Contributor Author

Looks good, but the unit tests are failing

Checks passing here now https://github.com/lightstep/terraform-provider-lightstep/pull/214/checks?sha=c4d6d19a2bf4487ac5886413192b937dd3fea770 (most recent robo commit doesn't have checks)

@erik-snow erik-snow requested a review from bcronin March 4, 2024 19:15
@erik-snow erik-snow merged commit c01e10a into main Mar 4, 2024
@erik-snow erik-snow deleted the add-pie-charts branch March 4, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcronin bcronin bcronin approved these changes

@ahiseley ahiseley Awaiting requested review from ahiseley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-snow @bcronin