Remove haskell and lsp-bench #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinderknecht
approved these changes
Oct 4, 2024
EduardoRFS
force-pushed
the
drop-debugger
branch
from
e13eb06 to
cad4b1f
Compare
EduardoRFS
force-pushed
the
drop-lsp-bench-and-haskell
branch
from
ca5d02a to
632b561
Compare
EduardoRFS
added a commit
that referenced
this pull request
Oct 20, 2024
* delete lsp-bench * remove haskell * update the flake lock
EduardoRFS
added a commit
that referenced
this pull request
Oct 20, 2024
* delete lsp-bench * remove haskell * update the flake lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #5 there is only one tool using Haskell in the project
lsp-bench, which is used to benchmark our LSP, while this tool is useful, it doesn't justify the overhead of having an entire Haskell stack.Currently Haskell is still present due to
shellcheck, but hopefully as part of #6 this can also be removed very soon.Related