This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
change font type to fix jenkins fe view #122
Open
JonasHillerDkd
wants to merge
5
commits into
liip:master
Choose a base branch
from
dkd:feature/92960-change_font_type_to_fix_jenkins_FE_view
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
change font type to fix jenkins fe view #122
JonasHillerDkd
wants to merge
5
commits into
liip:master
from
dkd:feature/92960-change_font_type_to_fix_jenkins_FE_view
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
suggested changes
Sep 14, 2018
Thanks for the PR! |
…ana and Helvetica as fallback
Hywan
reviewed
Mar 27, 2019
@@ -13,7 +13,7 @@ | |||
} | |||
|
|||
body { | |||
font: .9em/1.2em Source Sans Pro; | |||
font: .9em/1.2em Source Sans Pro, Arial, Verdana, Helvetica, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, keep only this line in your patch. The rest is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But i cleaned up the code format. I think it should be necessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Jenkins sever can't access the web font so i removed it and changed it to common font arts.