-
Notifications
You must be signed in to change notification settings - Fork 67
add bik bitv link rendering #123
base: master
Are you sure you want to change the base?
add bik bitv link rendering #123
Conversation
…o the BITV BITV 2.0 test steps links. Added the BIK BITV link rendering to the reporter template.
…ator at the BIK BITV 2.0 link rendering process.
@@ -369,6 +369,27 @@ <h2><%- result.level.charAt(0).toUpperCase() + result.level.substring(1).toLower | |||
) | |||
.join(', ') | |||
%> <code>#<%- result.code %></code></p> | |||
<p>BIK BITV Prüfschritt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part should go in the p.notes
element.
if (bikCodeMapItem.noteCode === noteCode) { | ||
_.map( | ||
bikCodeMapItem.bikTestSteps, | ||
function (bikTestStepsItem) { %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to be consistent with the rest of the file, please return a string instead of closing the <% … %>
, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it with the Return statement, but it returns nothing
do you know why?
BIK BITV Prüfschritt:
<% _.map(
result.noteCodes,
function (noteCode) {
_.map(
bikCodeMap,
function (bikCodeMapItem) {
if (bikCodeMapItem.noteCode === noteCode) {
_.map(
bikCodeMapItem.bikTestSteps,
function (bikTestStepsItem) {
return '<a href="' + bikTestStepsItem.url + '"> + bikTestStepsItem.name + '</a>';
}
)
}
}
)
}
)%>
<% } | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the empty line.
@@ -0,0 +1,2681 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where this file comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i created it manually. I investigated the diffrence beetwen the BITV Standard and the WCAG techniques. The result was the the BITV test steps and the WCAG techniques was similar if not even the same.
package.json
Outdated
@@ -20,8 +20,7 @@ | |||
"homepage": "https://github.com/liip/TheA11yMachine#readme", | |||
"main": "./lib/a11ym.js", | |||
"dependencies": { | |||
"HTML_CodeSniffer": "https://github.com/squizlabs/HTML_CodeSniffer#master", | |||
"async": "^2.1.4", | |||
"HTML_CodeSniffer": "git+https://github.com/squizlabs/HTML_CodeSniffer.git#d209ce54876657858a8a01528ad812cd234f37f0", "async": "^2.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is from #121, please consider removing it.
Thanks for the PR! I would be in favor of adding BITV codes if only I knew them :-). Is it something from an official law? |
This feature renders a link to the BITV 2.0 testing step, the german accessibility standard, to each, similar WCAG 2.0 Note Code.