Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heatmap #286

Merged
merged 5 commits into from
Jan 20, 2024
Merged

Fix heatmap #286

merged 5 commits into from
Jan 20, 2024

Conversation

yihming
Copy link
Member

@yihming yihming commented Jan 8, 2024

Consider 3 cases on showing groupby tick labels:

  • When show_sample_name=True, set yticklabels to sample_tick_labels;
  • When on_average=True, set yticklabels to cluster_ids;
  • When on_average=False, set yticklabels to [].

Tick label rotation:

  • Rename attrs_labelrotation to xticklabel_rotation, and set its default to 90.0.
  • Remove groupby_labelrotation as y tick labels don't need rotation.

No need to apply remove_unused_categories(), since pandas df.groupby(..., observed=True) would cover it.

@yihming yihming requested a review from bli25 January 8, 2024 05:23
@yihming yihming merged commit 89ca768 into master Jan 20, 2024
4 checks passed
@yihming yihming deleted the fix-plot branch January 20, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants