Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize pseudobulk and deseq2 functions #300

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Reorganize pseudobulk and deseq2 functions #300

merged 2 commits into from
Jun 2, 2024

Conversation

yihming
Copy link
Member

@yihming yihming commented Jun 1, 2024

Modify pseudobulk function:

  • Rename sample to groupby
  • Rename cluster to condition
  • Return a MultimodalData object, and don't write to the original data object
  • Enforce non-numeric attributes set in attrs to be categorical in the pseudobulk data object

Modify deseq2 function:

  • It takes 2 backend subfunctions _run_pydeseq2 and _run_rdeseq2. Default is _run_pydeseq2
  • Add compute_all parameter to decide if applying DE analysis to all count matrices
  • Add alpha parameter to allow user choose significance level for independent filtering to calculate adjusted p-values

Compatible with matplotlib v3.9+:

  • Change legend.legendHandles to legend.legend_handles, as v3.9+ removes legendHandles attribute.

Improve calc_dendrogram function:

  • Simplify logic on rep by using update_rep and X_from_rep utility functions

@yihming yihming requested a review from bli25 June 1, 2024 06:29
@bli25 bli25 merged commit 31c4e21 into master Jun 2, 2024
5 checks passed
@yihming yihming deleted the pseudo-deseq2 branch June 2, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants