-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check-remote-image-existence.yml: check remote image existence in templates #2513
base: master
Are you sure you want to change the base?
check-remote-image-existence.yml: check remote image existence in templates #2513
Conversation
4 image locations returns 404: https://github.com/lima-vm/lima/actions/runs/10092040673/job/27904864692?pr=2513#step:3:5
annotations can be checked here: https://github.com/lima-vm/lima/pull/2513/files |
In this PR, I also believe the following should be decided:
|
For AlmaLinux, those old releases are moved to a different URL. https://repo.almalinux.org/almalinux/8.9/README.txt https://vault.almalinux.org/8.9/cloud/x86_64/images/ Users are not supposed to configure the minor releases directly. it is supposed to upgrade to install 8.10 instead of 8.9: |
53f5aa3
to
ba92dec
Compare
ba92dec
to
509fb2e
Compare
…plates Signed-off-by: Norio Nomura <[email protected]> check-remote-image-existence.yml: use actions/checkout@v4 Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]> check-remote-image-existence.sh: change to tab Signed-off-by: Norio Nomura <[email protected]> check-remote-image-existence.sh: remove double quotation in [[ ]] Signed-off-by: Norio Nomura <[email protected]> check-remote-image-existence.sh: add space to `|` Signed-off-by: Norio Nomura <[email protected]>
509fb2e
to
4a460d3
Compare
|
I don't think If that should be part of And then you have to figure out when you want to signal a failure (return a non-0 exit code): If one of the images don't exist? If all images don't exist? If there isn't at least one image for the current architecture? If there isn't at least one image for each architecture? If this a feature for end-users, or just for Lima maintainers. If it is just for maintainers, then it doesn't need to be included in |
I think it should be scheduled to run periodically with cron. What do you think?
Thanks,