Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-remote-image-existence.yml: check remote image existence in templates #2513

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

norio-nomura
Copy link
Contributor

I think it should be scheduled to run periodically with cron. What do you think?

Thanks,

@norio-nomura
Copy link
Contributor Author

In this PR, I also believe the following should be decided:

  • What to do if a 404 image is found.
    • Should we create an issue? What should the content be? What if it's not fixed by the next cron job?
  • What is the appropriate cron schedule?

@afbjorklund
Copy link
Member

afbjorklund commented Jul 29, 2024

For AlmaLinux, those old releases are moved to a different URL.

https://repo.almalinux.org/almalinux/8.9/README.txt

https://vault.almalinux.org/8.9/cloud/x86_64/images/

Users are not supposed to configure the minor releases directly.

it is supposed to upgrade to install 8.10 instead of 8.9:

=> https://repo.almalinux.org/almalinux/8.10/cloud/

@norio-nomura norio-nomura force-pushed the ci-add-check-remote-image-existence branch 2 times, most recently from 53f5aa3 to ba92dec Compare August 7, 2024 02:44
@norio-nomura norio-nomura force-pushed the ci-add-check-remote-image-existence branch from ba92dec to 509fb2e Compare August 18, 2024 09:01
…plates

Signed-off-by: Norio Nomura <[email protected]>

check-remote-image-existence.yml: use actions/checkout@v4

Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]>

check-remote-image-existence.sh: change to tab

Signed-off-by: Norio Nomura <[email protected]>

check-remote-image-existence.sh: remove double quotation in [[ ]]

Signed-off-by: Norio Nomura <[email protected]>

check-remote-image-existence.sh: add space to `|`

Signed-off-by: Norio Nomura <[email protected]>
@norio-nomura norio-nomura force-pushed the ci-add-check-remote-image-existence branch from 509fb2e to 4a460d3 Compare August 18, 2024 23:34
@AkihiroSuda
Copy link
Member

limactl validate should have this feature?

@jandubois
Copy link
Member

limactl validate should have this feature?

I don't think limactl validate should require the user to be online, or to return different results based on network connectivity.

If that should be part of validate, then I think it should require an additional option, and be opt-in.

And then you have to figure out when you want to signal a failure (return a non-0 exit code): If one of the images don't exist? If all images don't exist? If there isn't at least one image for the current architecture? If there isn't at least one image for each architecture?

If this a feature for end-users, or just for Lima maintainers. If it is just for maintainers, then it doesn't need to be included in limactl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants