Add unit test for procnettcp.ParseAddress #2914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Redko <[email protected]>
jandubois
requested changes
Nov 16, 2024
| }, | ||
| { | ||
| input: "invalid:address", | ||
| expectedErrSubstr: `unparsable address "invalid:address"`, |
There was a problem hiding this comment.
Include the "expected length" part in the error string for this test case.
| }, | ||
| { | ||
| input: "0100007F:0050:00", | ||
| expectedErrSubstr: `0100007F:0050:00"`, |
There was a problem hiding this comment.
Suggested change
| expectedErrSubstr: `0100007F:0050:00"`, | |
| expectedErrSubstr: `unparsable address "0100007F:0050:00"`, |
| expectedErrSubstr: `0100007F:0050:00"`, | ||
| }, | ||
| { | ||
| input: "0100007F0050", |
There was a problem hiding this comment.
I would make this one 8 characters, to make sure it is rejected because it doesn't include a port number, and not because it is the wrong length.
Maybe move it to the top, as the missing colon is the first thing that is tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit test for the
procnettcp.ParseAddressfunction.