build: quote CC in Makefile #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
reviewed
Feb 5, 2025
|
@rfay Please add DCO |
Signed-off-by: Randy Fay <[email protected]>
rfay
force-pushed
the
20250205_quote_CC
branch
from
1aa6fa3 to
5a030c4
Compare
|
DCO Signoff added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some messy setups of${CC} in the bash environment may have two words, this PR just quotes $ (CC) in the Makefile so it doesn't break things in this situation. In my situation, I had
export CC='ccache clang'for some complex long-ago build of xtrabackup. With the quotes, this works in this situation. Seeand following.