Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor os and arch conditionals in Makefile #3206

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

afbjorklund
Copy link
Member

@afbjorklund afbjorklund commented Feb 8, 2025

Prepare for adding another operating system for guestagents.

There was a mix between hardcoded OS and dynamic Arch.

Correct some typos in the helper functions and documentation.

Just simple things like "aget" instead of agent, nothing much.

Prepare for adding another operating system for guestagents.

Correct some typos in the helper functions and documentation.

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund
Copy link
Member Author

Only the default "guestagents" has been changed, the rest still build Linux (or nothing).

@@ -81,6 +81,7 @@ help-targets:
        @echo
        @echo  'Targets for files in _output/share/lima/:'
        @echo  '- guestagents               : Build guestagents for archs enabled by CONFIG_GUESTAGENT_ARCH_*'
+       @echo  '                              Build guestagents for oses enabled by CONFIG_GUESTAGENT_OS_*'
        @echo  '- native-guestagent         : Build guestagent for native arch'
        @echo  '- additional-guestagents    : Build guestagents for archs other than native arch'
        @echo  '- <arch>-guestagent         : Build guestagent for <arch>: $(sort $(LINUX_GUESTAGENT_ARCHS))'

@AkihiroSuda AkihiroSuda added this to the v1.1 (tentative) milestone Feb 11, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 7ce6a7a into lima-vm:master Feb 11, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants