Bind QEMU GA socket only in virtio mode #3393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix part from #3387
On macOS:
Opened files before the change:
sudo lsof | grep ga.sock qemu-syst 42489 arturss 19u unix 0x490e394c874bdc89 0t0 /Users/arturss/.lima/default/ga.sock ssh 42501 arturss 13u unix 0x5de2ca7d01f8893 0t0 /Users/arturss/.lima/default/ga.sock ssh 42501 arturss 14u unix 0xe8fb28582c31df39 0t0 /Users/arturss/.lima/default/ga.sockOpened files after the change:
sudo lsof | grep ga.sock ssh 43396 arturss 14u unix 0xac705c05f6f9eaee 0t0 /Users/arturss/.lima/default/ga.sock ssh 43396 arturss 17u unix 0x5c371e023aafcc57 0t0 /Users/arturss/.lima/default/ga.sock