Feat add filter apis #125
Feat add filter apis #125
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .insert('user_filters', { | ||
| user_id: userId, | ||
| filter_id: filterId, | ||
| filter_json: JSON.stringify(filter) // TODO : clarify the type of the filter_json (bytea, string ???) |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| clientServer.logger, | ||
| (obj) => { | ||
| const filter = obj as Filter | ||
| // TODO : verify if the user is allowed to make requests for this user id |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| send(res, 404, errMsg('notFound', 'Cannot retrieve filter')) | ||
| return | ||
| } | ||
| const filter = JSON.parse(rows[0].filter_json as string) // TODO : clarify the type of the filter_json (bytea, string ???) |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
I made an error in the last pull request I merged myself. It is corrected in the last commit here (wrong callback call in validateParametersStrict). |
| .insert('user_filters', { | ||
| user_id: userId, | ||
| filter_id: filterId, | ||
| filter_json: JSON.stringify(filter) // TODO : clarify the type of the filter_json (bytea, string ???) |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| clientServer.logger, | ||
| (obj) => { | ||
| const filter = obj as Filter | ||
| // TODO : verify if the user is allowed to make requests for this user id |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| send(res, 404, errMsg('notFound', 'Cannot retrieve filter')) | ||
| return | ||
| } | ||
| const filter = JSON.parse(rows[0].filter_json as string) // TODO : clarify the type of the filter_json (bytea, string ???) |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
Conflicts to be resolved |
…ew configurations
… size of index.test.ts)
h1ppox99
force-pushed
the
feat-add-profiles
branch
from
425dec7
to
28402ff
Compare
|
This branch is ready for review @guimard |
*** add filter Apis *** + reorganised conf files for tests and other minor things