Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client server : implementing filters #131

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Conversation

h1ppox99
Copy link
Collaborator

No description provided.

@h1ppox99 h1ppox99 requested a review from guimard July 23, 2024 10:29

const removeWrongTypes = (types: string[], logger?: TwakeLogger): string[] => {
return types.filter((type) => {
// TODO : verify in @twake/utils if validEventTypes is correctly implemented

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
}

if (event_format === 'federation') {
// TODO: Implement restrictions for federationEventFields

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
/* Getting an event type functions */
//

// TODO : verify validity of the 2 functions below

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@@ -0,0 +1,50 @@
/* istanbul ignore file */

// TODO : Verify the content of this file while we implement the spec. There is absolutely no guarantee that this is correct.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@guimard guimard merged commit c558216 into full-id-service Jul 23, 2024
8 checks passed
@Mathixx Mathixx deleted the client-server/sync branch July 23, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants