Adding sql requests #91
Conversation
|
This PR looks to break really the test |
|
Well-noted, I look into it.
De: "Yadd" ***@***.***>
À: "linagora/ToM-server" ***@***.***>
Cc: "Wallaert Hippolyte, M." ***@***.***>, "Author" ***@***.***>
Envoyé: Vendredi 5 Juillet 2024 07:24:51
Objet: Re: [linagora/ToM-server] Adding sql requests (PR #91)
This PR looks to break really the test
—
Reply to this email directly, [ #91 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/BEQBYFJPTK35QDWLE32N553ZKYGYHAVCNFSM6AAAAABKMAXXE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZHEZTGMZQGY | unsubscribe ] .
You are receiving this because you authored the thread. Message ID: <linagora/ToM-server/pull/91/c2209933306 @ github . com>
…--
HIPPOLYTE WALLAERT
PÔLE EC-UI DU FORUM 4A DE L’ÉCOLE POLYTECHNIQUE
***@***.***
+33 06 42 09 34 40
***@***.***
[ http://www.nouveausiteforum.fr/ | www.xforum.binets.fr ]
|
…r better handling of optionnal parameters
…on and achieve sufficient test coverage. Register is still WIP as it needs refactoring to have cleaner code and some features need other endpoints to be implemented first to complete it. Also changed AuthenticationTypes typings but this is temporary.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| let initial_device_display_name | ||
| if (deviceRows.length > 0) { | ||
| // TODO : Refresh access tokens using refresh tokens and invalidate the previous access_token associated with the device |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| matrixDb | ||
| .get('users', ['name'], { | ||
| name: (auth.identifier as MatrixIdentifier).user, | ||
| password_hash: hash.sha256(auth.password) // TODO : Handle other hash functions |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| flows: flowContent | ||
| params: any | ||
| flows: Array<Record<string, string[]>> // those two types will be changed later on | ||
| // TODO : Correct typing |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
I saw you just add a new commit, is this branch ready ? |
|
This branch is ready |
Added new sql request needed for the development of the client-server API (the matrixDb in client server extends the db in the identity server, that is why the changes are done here first).
Created requests as general as possible in order to create future request faster when developing the client-server API.
Some more tests will be developed then to ensure a complete coverage of these very general methods.