PushPlatformValidationScenario: exit early if some failure endanger connection state #151
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Arsnael
reviewed
Oct 7, 2022
| 5.0 -> JmapEmail.submitEmails(recipientFeeder), | ||
| 30.0 -> openArbitrary.openArbitrary, | ||
| 5.0 -> JmapEmail.submitEmails(recipientFeeder).exitHereIfFailed, | ||
| 30.0 -> openArbitrary.openArbitrary.exitHereIfFailed, |
There was a problem hiding this comment.
Why those 2 actions specifically?
There was a problem hiding this comment.
Having a look at the Gatling simulation log: gatling_log.zip, I see these suspect log:
REQUEST submitEmails 1665053694055 1665053696510 KO j.i.IOException: Premature close
REQUEST submitEmails 1665053694332 1665053696517 KO j.i.IOException: Premature close
REQUEST emailGet 1665053788417 1665053788509 KO j.i.IOException: Premature close
REQUEST emailGet 1665053692357 1665053693488 KO j.i.IOException: Premature close
Which has not happened before 0.6.3.
There was a problem hiding this comment.
Would be nice to understand why :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could help avoids the simulation hanging forever when there were some users who could not open a WebSocket connection.
I took the inspiration from: c74dc64, gatling/gatling#2973 (comment)