Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-1163] Inject OpenPaaS user contacts into Tmail's auto-complete database #1215
[ISSUE-1163] Inject OpenPaaS user contacts into Tmail's auto-complete database #1215
Changes from 23 commits
0603398
b793e5b
6e678d5
64caa79
7920a68
3034856
422dc57
0cb1daf
b3f4e45
4044083
921d4ed
246835c
2d6213d
0a941ae
0934508
9522451
b2087dd
1fbf532
f188b1f
dcdc15f
7bd2df7
d95de64
aa008f4
98e68c7
a8bec38
98ef683
82c6afa
199aecd
4a1c7ae
564082b
890f7b5
543992d
ba36867
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use MailAddress here or it's fine as is? And throw an exception at the deserializer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course using stronger types in the data model indeed is always better. If we think this can easily be achieved then we shall go for it.