Split ContactsCollection mailet #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Nov 15, 2024
tmail-backend/mailets/src/main/scala/com/linagora/tmail/mailets/IndexContacts.java
Show resolved
Hide resolved
chibenwa
reviewed
Nov 15, 2024
tmail-backend/mailets/src/main/scala/com/linagora/tmail/mailets/IndexContacts.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Nov 15, 2024
tmail-backend/mailets/src/main/scala/com/linagora/tmail/mailets/IndexContacts.java
Show resolved
Hide resolved
HoussemNasri
force-pushed
the
split-contacts-collection
branch
2 times, most recently
from
01c3f47
to
cbce198
Compare
HoussemNasri
changed the title
chibenwa
approved these changes
Nov 18, 2024
- Removed ContactsCollection usage from mailetcontainer.xml in tests - Removed references of ContactsCollection from documentation - Removed all code belonging to ContactsCollection
…eplyWithAMQPWorkflowTest
HoussemNasri
force-pushed
the
split-contacts-collection
branch
from
22beb0b
to
8d4da21
Compare
Arsnael
approved these changes
Nov 19, 2024
| <mailet match="SenderIsLocal" class="com.linagora.tmail.mailets.ContactsCollection"> | ||
| <mailet match="SenderIsLocal" class="ContactExtractor"> |
There was a problem hiding this comment.
@HoussemNasri can you adapt this change to memory-app sample mailetcontainer.xml and potentially other apps too?
Frontend team rely on memory app for their test and it is failing java.lang.ClassNotFoundException: com.linagora.tmail.mailets.ContactsCollection. cc @hoangdat @tk-nguyen @tddang-linagora
There was a problem hiding this comment.
It's already adapted AFAIK.
There was a problem hiding this comment.
maybe mobile team mount outdated configuration file to container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1257
TODO
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of org.apache.james.transport.mailets.ContactExtractor$ExtractedContactsContactsCollectionleftovers (code, doc, tests, etc...)MemoryCalendarEventReplyWithAMQPWorkflowTestand useOpenPaasAmqpForwardAttribute.