ISSUE-1255 Implement JMAP CalendarEventCounter/accept method #1624
Conversation
| import org.apache.james.core.Username; | ||
| import org.reactivestreams.Publisher; | ||
|
|
||
| public interface CalendarEventRepository extends EventAttendanceRepository { |
There was a problem hiding this comment.
I hesitated about whether to rename EventAttendanceRepository to CalendarEventRepository, or instead, keep EventAttendanceRepository (dedicated to attendance status logic) and create a new CalendarEventRepository that extends it.
And I a bit tend slightly towards the second approach.
- To generate update calendar event based on proposed start and end dates.
…itory - Rename StandaloneEventAttendanceRepository to StandaloneEventRepository - Rename CalDavEventAttendanceRepository to CalDavEventRepository
vttranlina
changed the title
| val newCalendar = originalCalendar.copy() | ||
| val vEvent = newCalendar.getComponent[VEvent](Component.VEVENT).get() | ||
| validator.accept(vEvent) | ||
| updateEvent(vEvent, newStartDate, newEndDate) |
There was a problem hiding this comment.
Please confirm me, double checking RFC if needed, that counter only can update start and end and no other property of the event.
There was a problem hiding this comment.
I have check RFC 5546 #section-3.2.7 and related examples,
but the RFC does not exactly list fields should be updated from COUNTER.
I have gathered scattered pieces of information mentioned in the RFC:
- DTSTART, DTEND (implemented)
- LOCATION, ATTENDEE (not yet implemented in this PR)
I checked the linagora openpaas, we right now only support propose (DTSTART, DTEND)
Google Calendar is same
Which choice should it be?
There was a problem hiding this comment.
We can likely start with start+end but we may create an enhancement, (timeboxed) to support updates on other fields as well.
There was a problem hiding this comment.
I created a ticket for it: #1630
...s/src/test/scala/com/linagora/tmail/james/jmap/json/CalendarEventCounterSerializerTest.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/com/linagora/tmail/james/common/CalendarEventCounterAcceptMethodContract.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/com/linagora/tmail/james/common/CalendarEventCounterAcceptMethodContract.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/com/linagora/tmail/james/common/CalendarEventCounterAcceptMethodContract.scala
Outdated
Show resolved
Hide resolved
resolve #1255