Multiple fixes for Redis event bus #1629
Open
+310
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the Group So the consumer healthcheck work for Redis event bus group queues too.
So the test tests all components, not only EventbusConsumers
…bbit/Redis event bus group queues Otherwise: - Wrong queues to be monitored - Zombie existing RabbitMQEventBus group queues without consumers (result of a RabbitMQ -> Redis event bus switch) would force restarting RedisEventBus consumers everytime.
…hen Redis event bus When Redis event bus mode: `emailAddressContactEvent-workQueue-org.apache.james.events.TmailGroupRegistrationHandler$GroupRegistrationHandlerGroup` was created by Redis event bus (of course) `emailAddressContactEvent-workQueue-org.apache.james.events.GroupRegistrationHandler$GroupRegistrationHandlerGroup` was created by RabbitMQEventBus which should not.
simple reason: Redis handles the event bus key part, not RabbitMQ.
…P event bus(es) Fixes linagora#1609 As EventDeadLettersRedeliverService relies on the Set<EventBus>. Missing the event bus would fail to reprocess according events... Rabbit eventbus: `Event buses registered for EventDeadLettersRedeliverService: [mailboxEvent, jmapEvent, emailAddressContactEvent, tmailEvent]` Redis eventbus before: `Event buses registered for EventDeadLettersRedeliverService: [emailAddressContactEvent, tmailEvent]` Redis eventbus after: `Event buses registered for EventDeadLettersRedeliverService: [jmapEvent, mailboxEvent, emailAddressContactEvent, tmailEvent]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs apache/james-project#2685.
This resolves: