Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Some actions are not working when Semantics enabled #3086

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

[FIX] Some actions are not working when Semantics enabled #3086

wants to merge 42 commits into from
+1,012 −829

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Aug 14, 2024 •
edited
Loading

Issue related

#2977

Action affected

  1. Advanced Search
  • Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions
  • Overlap suggestion view with advanced search view
  • Advanced search view auto closed when click any field
  • (CHROME) Has attachment check-box still lost focus (click on it, but the view below got the click)
  • Advanced search dialog view cannot be closed when click advanced search icon
  • Select all button is clicked, even advanced search stay overlays
  • Select, Mark as read, Starred button is clicked in item email, even advanced search stay overlays
  • Has Attachment, All time, From button is clicked, even advanced search or suggestion search view stay overlays
  • Quick search and advanced search will show at the same time
  • Open quick search dialog, select in quick chip: From me , Last 7 days or Has attachment, after that we can not input text in quick search. Refer: [FIX] Some actions are not working when Semantics enabled #3086 (comment)
  • Focus is randomly in quick search after select options. Refer: [FIX] Some actions are not working when Semantics enabled #3086 (comment)
  1. App Grid
  • Cannot click item in app grid
  1. Mailbox Creator
  • Text field not focus when click
  1. Popup Menu
  • Cannot click item
  1. Dropdown Menu
  • Cannot click item
  1. Composer
  • Lost editor focus
  • Lost subject focus
  • Cannot click bottom option (RichText, Send, Draft,...)
  • Focus of body composer is lost after change font family
  • Focus indicator still display, but can not fill text in composer body after change color background
  • Composer in full screen still lost focus for the under layout. Refer: [FIX] Some actions are not working when Semantics enabled #3086 (comment)
  1. Rename Mailbox
  • Text Field missing focus
  1. Contact view
  • Text field not focus when click
  • Duplicate open Contact View
  1. Sort By
  • Cannot click item
  1. Language
  • Cannot change language
  1. Forward View
  • Input field lost focus when clicked
  1. Vacation View
  • Subject field cannot focus when clicked
  • Can not select time in vacation
  • Can not select text color in vacation form
  • Paragraph dialog & Order list dialog open twice and cannot be closed
  1. Search Mailbox, Email View
  • Text field not focus when click
  • Can not use delete button in keyboard in search bar for folder if user not click on this one more time
  1. Rich Text Toolbar
  • Text color dialog opens twice
  • Paragraph dialog & Order list dialog open twice and cannot be closed
  1. PDF Viewer
  • When I click to open PDF in list, list is closed
  1. Rule Filter
  • Focus is totally lost in quick form of creating email rule
  • Click outside button (Add action & Add condition) but in the same row, button still be clicked in create rule filter
  1. Dialog
  • Close dialog when clicking on empty area on dialog

Flutter Issue Related

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3086.

@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from 4d2dcdf to 3f4cfa0 Compare August 15, 2024 08:48
@hoangdat
Copy link
Member

hoangdat commented Aug 19, 2024 •
edited by dab246
Loading

  • Adr for semantic

@hoangdat
Copy link
Member

hoangdat commented Aug 19, 2024 •
edited by dab246
Loading

  • composer: lost focus when click onetime 🔥 🔥 🔥

@dab246 dab246 changed the title [WIP][HOT-FIX] Some actions are not working when Semantics enabled [HOT-FIX] Some actions are not working when Semantics enabled Aug 21, 2024
@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from c15cc6a to 1683f07 Compare August 21, 2024 11:36
@hoangdat hoangdat changed the title [HOT-FIX] Some actions are not working when Semantics enabled [FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@dab246 dab246 changed the title [FIX] Some actions are not working when Semantics enabled [HOT-FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@dab246 dab246 changed the title [HOT-FIX] Some actions are not working when Semantics enabled [FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@tddang-linagora
Copy link
Collaborator

Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions

Please check again
Env: preprod
Build mode: profile

Screen.Recording.2024-08-27.at.10.04.37.mov

@tddang-linagora
Copy link
Collaborator

tddang-linagora commented Aug 27, 2024 •
edited by dab246
Loading

Composer

Env: preprod
Build mode: profile

  • Text color dialog opens twice
Screen.Recording.2024-08-27.at.10.48.50.mov
  • Paragraph dialog & Order list dialog open twice and cannot be closed
Screen.Recording.2024-08-27.at.10.55.42.mov
Screen.Recording.2024-08-27.at.10.57.22.mov

dab246 added 22 commits February 28, 2025 01:46
@dab246
[Semantic] Fix input field lost focus when clicked in Search Mailbox …
2f21453 
…View
@dab246
[Semantic] Fix input field lost focus when clicked in Search Email Vi…
2e0463c 
…ew on Tablet/Mobile
@dab246
[Semantic] Fix lost subject focus in composer web
cdee690
@dab246
[Semantic] Fix text color dialog opens twice in composer
3e761ce
@dab246
[Semantic] Fix Paragraph dialog & Order list dialog open twice an…
593bbbc 
…d cannot be closed in composer
@dab246
[Semantic] Fix Has attachment checkbox still lost focus (click on i…
4156713 
…t, but the view below got the click)
@dab246
[Semantic] Fix can not use delete button in keyboard in search bar fo…
c4c809c 
…r folder if user not click on this one more time
@dab246
[Semantic] Fix attachment list dialog is closed when click to open pdf
0e311d2
@dab246
[Semantic] Fix can not expand sub folder in Mailbox View
9e771a9
@dab246
[Semantic] Fix Advanced Search dialog cannot closed when click advanc…
4b10bdf 
…ed search icon
@dab246
[Semantic] Fix focus is totally lost in quick form of creating email …
1edb79d 
…rule
@dab246
[Semantic] Fix Unexpected null value when create new email rule
6858933
@dab246
[Semantic] Fix can not select time in vacation
a564ec4
@dab246
[Semantic] Fix can not select Text color, Paragraph & `Order list…
5502f35 
…` in vacation form
@dab246
[Semantic] Fix use tab to change focus but focus is never go to bod…
efbb4a1 
…y of composer
@dab246
[Semantic] Fix select all button is clicked, even advanced search s…
1d8eec9 
…tay overlays
@dab246
[Semantic] Fix Select, Mark as read, Starred button is clicked,…
8085eac 
… even advanced search stay overlays
@dab246
[Semantic] Fix focus indicator still display, but can not fill text i…
73b8141 
…n composer body after change `color background`, `font name`
@dab246
[Semantic] Fix click outside button (Add action & Add condition) but …
c608691 
…in the same row, button still be clicked in create rule filter
@dab246
[Semantic] Fix quick search and advanced search will show at the same…
d7381a0 
… time
@dab246
[Semantic] Fix close dialog when clicking on empty area on dialog
233d88f
@dab246
[Semantic] Update html_editor_enhanced in pubspec.yaml
cda057b 
Signed-off-by: dab246 <[email protected]>
@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from 427358b to cda057b Compare February 28, 2025 02:54
@dab246
Copy link
Member Author

dab246 commented Mar 3, 2025

  • Open quick search dialog, select in quick chip: From me Last 7 days or Has attachment, after that we can not input text in quick search
  1. open quick search
  2. select From me
  3. try to typing in keyboard, text is not filled in quick search

Fixed.

Screen.Recording.2025-03-03.at.10.37.35.mov
  • focus is randomly in quick search after select options

Fixed

Screen.Recording.2025-03-03.at.10.55.26.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat Awaiting requested review from hoangdat

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dab246 @hoangdat @tddang-linagora @jay-athelas @Xola11