Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Some actions are not working when Semantics enabled #3086

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

[FIX] Some actions are not working when Semantics enabled #3086

wants to merge 39 commits into from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Aug 14, 2024 •
edited
Loading

Issue related

#2977

Action affected

  1. Advanced Search
  • Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions
  • Overlap suggestion view with advanced search view
  • Advanced search view auto closed when click any field
  • (CHROME) Has attachment check-box still lost focus (click on it, but the view below got the click)
  • Advanced search dialog view cannot be closed when click advanced search icon
  • Select all button is clicked, even advanced search stay overlays
  • Select, Mark as read, Starred button is clicked in item email, even advanced search stay overlays
  • Has Attachment, All time, From button is clicked, even advanced search or suggestion search view stay overlays
  • Quick search and advanced search will show at the same time
  • Open quick search dialog, select in quick chip: From me , Last 7 days or Has attachment, after that we can not input text in quick search
  1. App Grid
  • Cannot click item in app grid
  1. Mailbox Creator
  • Text field not focus when click
  1. Popup Menu
  • Cannot click item
  1. Dropdown Menu
  • Cannot click item
  1. Composer
  • Lost editor focus
  • Lost subject focus
  • Cannot click bottom option (RichText, Send, Draft,...)
  • Focus of body composer is lost after change font family
  • Focus indicator still display, but can not fill text in composer body after change color background
  1. Rename Mailbox
  • Text Field missing focus
  1. Contact view
  • Text field not focus when click
  • Duplicate open Contact View
  1. Sort By
  • Cannot click item
  1. Language
  • Cannot change language
  1. Forward View
  • Input field lost focus when clicked
  1. Vacation View
  • Subject field cannot focus when clicked
  • Can not select time in vacation
  • Can not select text color in vacation form
  • Paragraph dialog & Order list dialog open twice and cannot be closed
  1. Search Mailbox, Email View
  • Text field not focus when click
  • Can not use delete button in keyboard in search bar for folder if user not click on this one more time
  1. Rich Text Toolbar
  • Text color dialog opens twice
  • Paragraph dialog & Order list dialog open twice and cannot be closed
  1. PDF Viewer
  • When I click to open PDF in list, list is closed
  1. Rule Filter
  • Focus is totally lost in quick form of creating email rule
  • Click outside button (Add action & Add condition) but in the same row, button still be clicked in create rule filter
  1. Dialog
  • Close dialog when clicking on empty area on dialog

Flutter Issue Related

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3086.

@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from 4d2dcdf to 3f4cfa0 Compare August 15, 2024 08:48
@hoangdat
Copy link
Member

hoangdat commented Aug 19, 2024 •
edited by dab246
Loading

  • Adr for semantic

@hoangdat
Copy link
Member

hoangdat commented Aug 19, 2024 •
edited by dab246
Loading

  • composer: lost focus when click onetime 🔥 🔥 🔥

@dab246 dab246 changed the title [WIP][HOT-FIX] Some actions are not working when Semantics enabled [HOT-FIX] Some actions are not working when Semantics enabled Aug 21, 2024
@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from c15cc6a to 1683f07 Compare August 21, 2024 11:36
@hoangdat hoangdat changed the title [HOT-FIX] Some actions are not working when Semantics enabled [FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@dab246 dab246 changed the title [FIX] Some actions are not working when Semantics enabled [HOT-FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@dab246 dab246 changed the title [HOT-FIX] Some actions are not working when Semantics enabled [FIX] Some actions are not working when Semantics enabled Aug 23, 2024
@tddang-linagora
Copy link
Contributor

Cannot click any actions (hasAttachment/Last7Days/FromMe) in suggestions

Please check again
Env: preprod
Build mode: profile

Screen.Recording.2024-08-27.at.10.04.37.mov

@tddang-linagora
Copy link
Contributor

tddang-linagora commented Aug 27, 2024 •
edited by dab246
Loading

Composer

Env: preprod
Build mode: profile

  • Text color dialog opens twice
Screen.Recording.2024-08-27.at.10.48.50.mov
  • Paragraph dialog & Order list dialog open twice and cannot be closed
Screen.Recording.2024-08-27.at.10.55.42.mov
Screen.Recording.2024-08-27.at.10.57.22.mov

@dab246
Fix Paragraph dialog & Order list dialog open twice and cannot be…
ca3db0c 
… closed in composer
@dab246
Fix Has attachment checkbox still lost focus (click on it, but the …
34b1419 
…view below got the click)
@dab246
Fix can not use delete button in keyboard in search bar for folder if…
5bc6a48 
… user not click on this one more time
@dab246
Fix attachment list dialog is closed when click to open pdf
3925230
@dab246
Fix can not expand sub folder in Mailbox View
4858dd1
@dab246
Fix Advanced Search dialog cannot closed when click advanced search icon
7693e53
@dab246
Fix focus is totally lost in quick form of creating email rule
6c75976
@dab246
Fix Unexpected null value when create new email rule
2fb8a6b
@dab246
Fix can not select time in vacation
054c103
@dab246
Fix can not select Text color, Paragraph & Order list in vacati…
2a27c23 
…on form
@dab246
Fix use tab to change focus but focus is never go to body of composer
288eb55
@dab246
Fix select all button is clicked, even advanced search stay overlays
07c0475
@dab246
Fix Select, Mark as read, Starred button is clicked, even advan…
49f5484 
…ced search stay overlays
@dab246
Fix focus indicator still display, but can not fill text in composer …
940b94d 
…body after change `color background`, `font name`
@dab246 dab246 force-pushed the hotfix/ux-broken-when-semantics-enabled branch from f2566b9 to 940b94d Compare October 22, 2024 09:15
@dab246
Copy link
Member Author

dab246 commented Oct 22, 2024

  • rebase with main to have new update in Search

Done

  • select color in composer, but input is focus also in from field

Cannot be reproduced

@dab246 dab246 changed the base branch from refactor to master October 22, 2024 09:16
@hoangdat
Copy link
Member

hoangdat commented Nov 1, 2024

  • build v0.13.4-feat-semantic-01 and waiting for deployment to canary on next monday

@hoangdat
Copy link
Member

hoangdat commented Nov 1, 2024 •
edited by dab246
Loading

  • click outside button but in the same row, button still be clicked
Screen.Recording.2024-11-01.at.18.49.12.mov

@hoangdat
Copy link
Member

hoangdat commented Nov 1, 2024

  • focus is randomly in quick search after select options
Screen.Recording.2024-11-01.at.19.08.07.mov

@hoangdat
Copy link
Member

hoangdat commented Nov 1, 2024 •
edited by dab246
Loading

  • quick search and advanced search will show at the same time
Screen.Recording.2024-11-01.at.19.08.07.mov

@dab246
Fix click outside button (Add action & Add condition) but in the same…
3bdde7d 
… row, button still be clicked in create rule filter
@dab246
Copy link
Member Author

dab246 commented Nov 6, 2024

  • click outside button but in the same row, button still be clicked

Screen.Recording.2024-11-01.at.18.49.12.mov

Fixed

Screen.Recording.2024-11-06.at.10.21.56.mov

@hoangdat
Copy link
Member

hoangdat commented Nov 8, 2024

  • composer in full screen still lost focus for the under layout
Screen.Recording.2024-11-08.at.10.08.10.mov

@dab246
Copy link
Member Author

dab246 commented Nov 8, 2024 •
edited
Loading

  • quick search and advanced search will show at the same time

Fixed

Screen.Recording.2024-11-08.at.15.43.59.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat Awaiting requested review from hoangdat

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dab246 @hoangdat @tddang-linagora @jay-athelas @Xola11