-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display limits of email recovery #3281
Open
florentos17
wants to merge
3
commits into
master
Choose a base branch
from
Display-Limits-of-Email-Recovery
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentos17
force-pushed
the
Display-Limits-of-Email-Recovery
branch
from
November 18, 2024 11:04
a4dab10
to
57777f7
Compare
This curious thing is happening: when accessing the recover deleted messages panel, at first an error is thrown, but when i trigger a hot reload, then everything is fine: IMG_0450.movthe method is this: String getRestorationHorizon(BuildContext context) {
return ((_session
?.props[0] as Map<CapabilityIdentifier, CapabilityProperties>?)
?[capabilityDeletedMessagesVault]
?.props[0] as Map<String, dynamic>) // line causing the error
['restorationHorizon'];
} and the error is |
This PR has been deployed to https://linagora.github.io/tmail-flutter/3281. |
florentos17
force-pushed
the
Display-Limits-of-Email-Recovery
branch
from
November 20, 2024 15:08
7ba818f
to
aa8edd1
Compare
florentos17
force-pushed
the
Display-Limits-of-Email-Recovery
branch
from
November 20, 2024 15:11
aa8edd1
to
de6b5e4
Compare
florentos17
commented
Nov 20, 2024
lib/features/email_recovery/presentation/email_recovery_controller.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tackling the issue 3219 (duplicated with the issue 3274)