Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display limits of email recovery #3281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

florentos17
Copy link
Collaborator

tackling the issue 3219 (duplicated with the issue 3274)

@florentos17
Copy link
Collaborator Author

florentos17 commented Nov 18, 2024

This curious thing is happening: when accessing the recover deleted messages panel, at first an error is thrown, but when i trigger a hot reload, then everything is fine:

IMG_0450.mov

the method is this:

String getRestorationHorizon(BuildContext context) {
    return ((_session
        ?.props[0] as Map<CapabilityIdentifier, CapabilityProperties>?)
        ?[capabilityDeletedMessagesVault]
        ?.props[0] as Map<String, dynamic>) // line causing the error
        ['restorationHorizon'];
  }

and the error is Type 'Null' is not a subtype of type 'Map<String, dynamic>' in type cast

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3281.

@florentos17 florentos17 force-pushed the Display-Limits-of-Email-Recovery branch from 7ba818f to aa8edd1 Compare November 20, 2024 15:08
@florentos17 florentos17 force-pushed the Display-Limits-of-Email-Recovery branch from aa8edd1 to de6b5e4 Compare November 20, 2024 15:11
@florentos17
Copy link
Collaborator Author

florentos17 commented Nov 20, 2024

the issue i had the other day is now resolved, everything is working fine ! it looks like this
Screenshot from 2024-11-20 16-05-37

in the web version, the options in the dropdown are filtered out so that "30 days" and more do not show if the horizon is 15 days for example. but in the mobile version, the period is selected with this widget (same as the one we get by clicking the little calendar icon in the web version) and i did not want to change the suggested options because the widget is also used for other features.
Screenshot from 2024-11-20 16-05-45

@florentos17 florentos17 marked this pull request as ready for review November 21, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant