Skip to content

Commit

Permalink
✅Fixed storage e2e test for S3
Browse files Browse the repository at this point in the history
  • Loading branch information
shepilov committed Nov 5, 2024
1 parent 20ef64f commit 2c5cf0b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export default class S3ConnectorService implements StorageConnectorAPI {
break;
}
} catch (e) {
logger.error("Error getting information from S3", e);
logger.error(e, `Error getting information from S3 for path: ${path}`);
}

if (i === tries) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ export default class StorageService extends TdriveService<StorageAPI> implements
}

exists(path: string, options?: ReadOptions): Promise<boolean> {
return this.getConnector().exists(path, options);
//TODO[ASH] check for all the file chunks
return this.getConnector().exists(path + "/chunk1", options);
}

async write(path: string, stream: Stream, options?: WriteOptions): Promise<WriteMetadata> {
Expand Down
2 changes: 1 addition & 1 deletion tdrive/backend/node/src/services/files/services/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ export class FileServiceImpl {
id: externalId,
company_id: "00000000-0000-4000-0000-000000000000",
});
const exist = await gr.platformServices.storage.exists(getFilePath(file) + "/chunk1");
const exist = await gr.platformServices.storage.exists(getFilePath(file));
if (exist) {
return { exist: true, file };
} else {
Expand Down
2 changes: 1 addition & 1 deletion tdrive/docker-compose.tests.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "2"
version: "3"

services:
# rabbitmq:
Expand Down

0 comments on commit 2c5cf0b

Please sign in to comment.