Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Dragndrop feature to move a file into a folder (#138) #148

Merged
merged 36 commits into from
Sep 4, 2023

Conversation

Greemty
Copy link
Contributor

@Greemty Greemty commented Jul 10, 2023

This feature is implemented in its simplest version.

Resume of the feature :
You are able to drag a unique file (not folders) and drop it above a folder. This dragged file will be moved in the folder. A little info message is displayed to confirm the action.

Tools:

To do:

  • new language variable has been added for the info message. Yet just translated in French and English.
  • Add highlights for over folder; need to create a HandleDragOver function...

Possible improvements :

  • moving multiple files at once
  • moving folder into folder (need of recursion for the folder content)

Demo Video

Enregistrement.de.l.ecran.2023-07-10.a.16.51.25.mov

@Greemty Greemty changed the title ✨ Dragndrop feature to move a file into a folder ✨ Dragndrop feature to move a file into a folder (#138) Jul 10, 2023
@chibenwa
Copy link
Member

Could you record a little video and upload it here?

It makes it easier to evaluate the resulting UX and is pretty quick to record.

@Greemty Greemty self-assigned this Jul 11, 2023
@Greemty Greemty linked an issue Jul 11, 2023 that may be closed by this pull request
@shepilov
Copy link
Member

@Greemty could you please highlight the place where you are dropping the file and remove all the elements except the file name from the item that you are dragging
image

@Greemty
Copy link
Contributor Author

Greemty commented Jul 28, 2023

Now the code for the modal has been simplified. Furthermore, now folder are highlighted when dragging a file over and dragged elements are just the file name.
A video example :

Enregistrement.de.l.ecran.2023-07-28.a.14.24.22.mov

In order to work you must run yarn add @dnd-kit/core

@Greemty Greemty requested review from shepilov and Aymerix01 July 28, 2023 12:35
@Aymerix01 Aymerix01 removed their request for review July 28, 2023 12:39
@shepilov shepilov merged commit 5fd29bb into main Sep 4, 2023
@shepilov shepilov deleted the dragndrop-feature-to-move-files branch September 4, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Drag and drop to move files between folders
4 participants