Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#50 user picker UI improvements #444

Merged
merged 43 commits into from
May 13, 2024
Merged

Conversation

ericlinagora
Copy link
Contributor

@ericlinagora ericlinagora commented Mar 12, 2024

About improvements called for in #50

  • Show when user results are truncated
  • More better layout and colours even in dark-mode
  • Keyboard navigation
  • Clarify rights to be added

@ericlinagora ericlinagora changed the title 50 user picker UI improvements #50 user picker UI improvements Mar 12, 2024
@ericlinagora ericlinagora linked an issue Mar 12, 2024 that may be closed by this pull request
3 tasks
@ericlinagora ericlinagora marked this pull request as draft April 2, 2024 11:08
@ericlinagora ericlinagora force-pushed the 50-user-picker-ui-improvements branch from d84db0a to 090b687 Compare April 2, 2024 16:31
@ericlinagora ericlinagora force-pushed the 50-user-picker-ui-improvements branch from aa80e19 to ea63175 Compare April 7, 2024 16:27
@ericlinagora ericlinagora marked this pull request as ready for review April 7, 2024 16:59
@ericlinagora ericlinagora force-pushed the 50-user-picker-ui-improvements branch from ea63175 to 59ef69d Compare April 9, 2024 02:37
@ericlinagora ericlinagora marked this pull request as draft April 11, 2024 22:14
@ericlinagora ericlinagora marked this pull request as ready for review April 29, 2024 08:21
@shepilov
Copy link
Member

Small UI/UX improvements:

  1. Make the "edit" icon the same color as label
image
  1. The "Copy link" button should be the same in green state as in blue
image
  1. The "remove password" modal window should look like this, without red color and with this text and buttons order
image
  1. There shouldn't be a border between input and select, also the background color should be the same
image
  1. When a user is the owner of the file, he should be displayed in the list like this
image
  1. For the search results, the selected item should have a grey hoover and all the area should be clickable
image
  1. Reduce the margin between input and search results
image
  1. Add the "Done" button to the modal window, this button only closes the window
image
  1. Remove the red color everywhere for "no access"
image

@ericlinagora
Copy link
Contributor Author

  • 1 Make the "edit" icon the same color as label
    • done
  • 2 The "Copy link" button should be the same in green state as in blue
    • done - just set a big width hopefully big enough for future translations
  • 3 The "remove password" modal window should look like this, without red color and with this text and buttons order
    • the dialog in the screen shot is about deleting the link not the password, ignoring the text. Changed order, removed icon, made button blue. There's also two confirmation dialogs. Translation keys are welcome.
  • 4 There shouldn't be a border between input and select, also the background color should be the same
    • don't think there is one, already is the same
  • 5 When a user is the owner of the file, he should be displayed in the list like this
    • We need a way to change the rights of the file creator though, so where to put it ? There isn't really a "owner" concept. Drawing is unclear, if user is owner, creator, or both, to disable editing rights. No answer to questions.
  • 6 For the search results, the selected item should have a grey hoover and all the area should be clickable
    • done
  • 7 Reduce the margin between input and search results
    • done, but because we are incapable of getting dimensions, just a guess
  • 8 Add the "Done" button to the modal window, this button only closes the window
    • done
  • 9 Remove the red color everywhere for "no access"
    • done

@ericlinagora ericlinagora force-pushed the 50-user-picker-ui-improvements branch from 46300ad to 4b86640 Compare April 30, 2024 13:09
"components.public-link-security_expiration_removal_no_password": "Предупреждение: о удалении срока действия общедоступной ссылки, что делает её доступной для любого, кто знает её",
"components.public-link-security_expiration_removal_but_password": "Предупреждение: о удалении срока действия общедоступной ссылки, что делает её доступной для любого, кто знает пароль",
"components.public-link-security_expiration_removal_no_password": "Это делает документ доступным для любого, у кого есть эта ссылка",
"components.public-link-security_expiration_removal_but_password": "Это делает её доступной для любого, кто знает пароль",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If google translate serves me well, this looks like more than fixing the language but a rephrasing of it, if you can do the en too so it suits better, I'll then do the fr ?

@ericlinagora ericlinagora merged commit 3e2adf9 into main May 13, 2024
7 checks passed
@ericlinagora ericlinagora deleted the 50-user-picker-ui-improvements branch May 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User picker does not work well
2 participants