Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Webdav connector to the Twake Drive #643

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

Conversation

rumata-feathers
Copy link
Collaborator

@rumata-feathers rumata-feathers commented Aug 27, 2024

WebDAV implementation

Description

This is implementation the WebDAV protocol for our application using the nephele library.
Key components of this implementation include:

  • Creating new 'webdav' service
  • Custom adapter class to interface
  • Resource class wrapper for drive items
  • Device authorisation
  • Implementing locks for the drive items

Related Issue

#573

Motivation and Context

WebDAV protocol is needed for desktop synchronisation

How Has This Been Tested?

  1. Manual testing using curl requests to simulate various WebDAV operations
  2. Practical testing by mounting the WebDAV server as a network drive:
    • Tested on macOS Sonoma
    • Tested file creation, deletion, and modification through the mounted drive

Testing environment:

  • Native explorer
  • ACCOUNTS_TYPE=internal

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added the Signed-off-by statement at the end of my commit message.

@rumata-feathers rumata-feathers requested review from MontaGhanmy, shepilov and ericlinagora and removed request for MontaGhanmy and shepilov August 27, 2024 14:15
Comment on lines +37 to +38
@Column("timeout", "number")
timeout: number;
Copy link
Member

@chibenwa chibenwa Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A duration without unit? at least in a comment...

@ericlinagora ericlinagora force-pushed the webdav-express branch 4 times, most recently from c116712 to 9c8b86f Compare October 12, 2024 14:08
… use that. Fastify plugin warning FSTWRN002

(Not sure this wasn't there before)

 [FSTWRN002] FastifyWarning: The routes plugin being registered mixes async and callback styles, which will result in an error in `fastify@5`
@ericlinagora
Copy link
Contributor

rclone for testing webdav:

  • copy url in twake drive account settings
  • rclone config for interactive, pick webdav, vendor = other, no user/pass (it's in the url), lets say you called the remote td
  • rclone lsl td: should list My Drive
  • Debug flags: -vv for debug level, request debugging at https://rclone.org/docs/#dump-flag-flag-flag

The config file look like:

$ cat ~/.config/rclone/rclone.conf 
[td]
type = webdav
url = http://f2a30b0f-ac2f-4a87-b0d5-c718b0d3b0e2:53503dce-9e7b-4f2d-9bd0-7a894386ce27@localhost:4000/internal/services/webdav/v1/webdav/My%20Drive/
vendor = other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants