Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix size 0 (number) transformed into empty string #715

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

MontaGhanmy
Copy link
Collaborator

Description

The ORM connector for mongo is storing size for empty folders supposedly 0 as empty string. This PR solves it by accounting for the "number" type when transforming values before insertion into the db/collection.

Related Issue

#704

@MontaGhanmy MontaGhanmy added this to the v1.0.6 milestone Oct 27, 2024
@MontaGhanmy MontaGhanmy self-assigned this Oct 27, 2024
@MontaGhanmy MontaGhanmy marked this pull request as ready for review October 27, 2024 22:01
@ericlinagora ericlinagora linked an issue Oct 28, 2024 that may be closed by this pull request
@shepilov shepilov merged commit b4e7621 into main Oct 30, 2024
7 checks passed
@MontaGhanmy MontaGhanmy deleted the fix_db_value_transformer_zero_number branch November 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Messed up sorting by size if there are empty folders
3 participants