Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically register the metics of PooledByteBufAllocator.DEFAULT #5916

Merged
merged 9 commits into from
Nov 25, 2024
Merged

Automatically register the metics of PooledByteBufAllocator.DEFAULT #5916

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79f8c06
Add metrics about PooledByteBufAllocator
Bue-von-hon Sep 18, 2024
bcf690f
Merge branch 'main' into armeria-2633
Bue-von-hon Sep 25, 2024
984ae7c
Merge branch 'main' into armeria-2633
Bue-von-hon Oct 14, 2024
e0a2b14
Merge branch 'main' into armeria-2633
Bue-von-hon Nov 16, 2024
b089356
Modify the method signature to use default values instead of requirin…
Bue-von-hon Nov 16, 2024
ecf6fda
Fix lint
Bue-von-hon Nov 16, 2024
5b3a182
Add javadoc
Bue-von-hon Nov 16, 2024
4441e69
Automatically register the default Netty allocator metrics
ikhoon Nov 21, 2024
c8ac9d4
Merge branch 'main' into armeria-2633
Bue-von-hon Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/main/java/com/linecorp/armeria/common/metric/MoreMeterBinders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,26 @@

import com.google.common.collect.ImmutableList;

import com.linecorp.armeria.common.Flags;
import com.linecorp.armeria.common.annotation.UnstableApi;
import com.linecorp.armeria.internal.common.util.CertificateUtil;

import io.micrometer.core.instrument.binder.MeterBinder;
import io.micrometer.core.instrument.binder.netty4.NettyAllocatorMetrics;
import io.netty.buffer.PooledByteBufAllocator;
import io.netty.channel.EventLoopGroup;

/**
* Provides useful {@link MeterBinder}s to monitor various Armeria components.
*/
public final class MoreMeterBinders {

static {
// Bind the default Netty allocator metrics to the default MeterRegistry.
new NettyAllocatorMetrics(PooledByteBufAllocator.DEFAULT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: armeria always initializes this class when a client or server is built

.bindTo(Flags.meterRegistry());
}

/**
* Returns a new {@link MeterBinder} to observe Netty's {@link EventLoopGroup}s. The following stats are
* currently exported per registered {@link MeterIdPrefix}.
Expand Down
Loading