-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github action adopt uv #57
Conversation
darjeeling
commented
Nov 13, 2024
- adopt uv in github action to test a little faster
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 81.30% 81.51% +0.20%
==========================================
Files 23 24 +1
Lines 706 714 +8
==========================================
+ Hits 574 582 +8
Misses 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
755a151
to
bab9734
Compare
Thanks for trying to improve. But I'm not sure this approach is good. |
@hexoul It seems like uv is becoming the de facto. 😅 |
Could you share a number on how much faster the tests run? |
@ikhoon |
@darjeeling What I meant was, I preferred using uv. 😉 |
Well, my two cents is that using uv has more upside rather than downside. Many Python projects these days (including product engineering) begin to start using uv due to performance issue of pip, I think that we can just start to use it and replace it later if the uv makes any trouble. But we should only use standard feature only. |
After taking a look more into pros/cons from many sources and arguments in the thread @minwoox referred, I weakly agreed. Except for license issue, uv looks cool and can rollback if problem occurs as @corona10 said. However, performance issue from pip is not sensitive in this project and there are ongoing discussions. So, adopting uv makes sense, but can we say that now is good time to apply? |
Right, we don't have any performance issues with pip because this project is relatively small. |
Thanks @darjeeling for your interest and contribution to centraldogma-python. This project is mostly maintained by contributing @hexoul personal effort. I don't want to use his resources aside from bug fixes and new features. If there is a problem with CI builds, we need to fix it. However, if we simply want to try it out, I think it's not too late to do it the next time we feel a problem in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all comments, supports and considerations. Let us try.