Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action adopt uv #57

Merged
merged 1 commit into from
Dec 11, 2024
Merged

github action adopt uv #57

merged 1 commit into from
Dec 11, 2024

Conversation

darjeeling
Copy link
Contributor

  • adopt uv in github action to test a little faster

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (c2f1f31) to head (bab9734).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   81.30%   81.51%   +0.20%     
==========================================
  Files          23       24       +1     
  Lines         706      714       +8     
==========================================
+ Hits          574      582       +8     
  Misses        132      132              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexoul
Copy link
Collaborator

hexoul commented Nov 24, 2024

Thanks for trying to improve. But I'm not sure this approach is good.
From invoked Github action jobs, there is no big difference. Meanwhile, dependency will be added and maintenance cost will be increased. uv is not de facto now.

@minwoox
Copy link

minwoox commented Nov 28, 2024

@ikhoon
Copy link
Contributor

ikhoon commented Nov 29, 2024

  • adopt uv in github action to test a little faster

Could you share a number on how much faster the tests run?

@darjeeling
Copy link
Contributor Author

@ikhoon
in most cases, 30 seconds faster for installation

@darjeeling
Copy link
Contributor Author

@minwoox IMHO, we have other tools that support almost same format. so we can change other tool if it's not standard

@minwoox
Copy link

minwoox commented Nov 29, 2024

@darjeeling What I meant was, I preferred using uv. 😉

@corona10
Copy link
Contributor

Well, my two cents is that using uv has more upside rather than downside.
(The only downside would be future license issues if Astral change their policy)
Since uv provides a drop-in-replacement interface with pip, there will be no issue compared to using pip unless we use a non-standard feature that is only provided by uv.

Many Python projects these days (including product engineering) begin to start using uv due to performance issue of pip, I think that we can just start to use it and replace it later if the uv makes any trouble.

But we should only use standard feature only.

@hexoul
Copy link
Collaborator

hexoul commented Nov 30, 2024

After taking a look more into pros/cons from many sources and arguments in the thread @minwoox referred, I weakly agreed. Except for license issue, uv looks cool and can rollback if problem occurs as @corona10 said. However, performance issue from pip is not sensitive in this project and there are ongoing discussions. So, adopting uv makes sense, but can we say that now is good time to apply?

@minwoox
Copy link

minwoox commented Dec 4, 2024

performance issue from pip is not sensitive

Right, we don't have any performance issues with pip because this project is relatively small.
It's just that uv is getting popular, and since we can always revert it so, there was no reason not to give it a try.
Since you're maintaining this repository, it's your call. I will go along with whatever decision you make. 😉

@ikhoon
Copy link
Contributor

ikhoon commented Dec 6, 2024

Thanks @darjeeling for your interest and contribution to centraldogma-python. This project is mostly maintained by contributing @hexoul personal effort. I don't want to use his resources aside from bug fixes and new features.

If there is a problem with CI builds, we need to fix it. However, if we simply want to try it out, I think it's not too late to do it the next time we feel a problem in pip.

Copy link
Collaborator

@hexoul hexoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all comments, supports and considerations. Let us try.

@hexoul hexoul merged commit 242cfe5 into line:main Dec 11, 2024
24 checks passed
@hexoul hexoul added this to the 0.5.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants