Allow user pick their own logger with custom config instead #1455
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mokuzon
reviewed
Nov 19, 2024
| @@ -97,6 +97,8 @@ public ApiClientBuilder(URI apiEndPoint, Class<T> clientClass, ExceptionBuilder | |||
|
|
|||
| private Integer maxRequestsPerHost = 5; | |||
|
|
|||
| private boolean usingDefaultLogger = true; // Just kept the same behavior as the original code | |||
There was a problem hiding this comment.
This comment is redundant, people who do not see this PR will be confused by the term original code and should be deleted.
Comment on lines
30
to
33
| static Interceptor loggingInterceptor() { | ||
| final Logger slf4jLogger = LoggerFactory.getLogger("com.linecorp.bot.client.wire"); | ||
| return new HttpLoggingInterceptor(slf4jLogger::info) | ||
| .setLevel(HttpLoggingInterceptor.Level.BODY); |
There was a problem hiding this comment.
[Q] Why is code similar to ApiClientBuilder's buildLoggingInterceptor() needed here?
There was a problem hiding this comment.
nice catch @mokuzon , it is duplicated!
I removed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation for this discussion #1415