Detect unloaded files under lib directory #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
commented
Apr 10, 2025
| @@ -34,7 +34,7 @@ jobs: | |||
| - run: gem install bundler | |||
| - run: bundle install | |||
| - run: bundle exec rubocop | |||
| - run: bundle exec rspec | |||
| - run: rake test | |||
There was a problem hiding this comment.
maintainer: please don't call bundle exec rspec. It fails even in your local after merging this change.
Yang-33
commented
Apr 10, 2025
Comment on lines
38
to
40
| - run: bundle exec yard stats ./lib/line/bot/v2 --fail-on-warning | ||
| - run: bundle exec rbs collection install | ||
| - run: bundle exec rbs -I sig validate |
There was a problem hiding this comment.
I'll move this into Rakefile later. I want to put bundle exec rake ci here finally
mokuzon
approved these changes
Apr 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Yang-33
force-pushed
the
detect-unload-file-under-lib
branch
from
584167b to
3a780c7
Compare
Yang-33
commented
Apr 18, 2025
|
|
||
| desc "Run normal tests (exclude no_missing_require_* specs)" | ||
| task :test_normal do | ||
| sh "bundle exec rspec --exclude-pattern 'spec/line/bot/line_bot_api_gem_spec.rb,spec/line/bot/line_bot_gem_spec.rb'" |
There was a problem hiding this comment.
--exclude-pattern allows multiple target when we use comma like --exclude-pattern 'A,B,C', though --exclude-pattern 'A' --exclude-pattern 'B' doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds specs to detect files that are not required yet by
required line-bot-apiorrequire line/bot. However, since RSpec runs tests in the same process, it heavily depends on the order of test execution. Additionally, afterrequire line-bot-api, we cannot clean up and then cannot callrequire line/bot.Therefore, this change makes sure that important tests are run in a separate process. To avoid having to manually enter commands locally with test separation in mind, this change describes all the tests in the Rakefile's test task to hide the details of test execution.