-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods WindowHandle::is_resizable etc #2115
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly curious about the point of these method. mostly its querying state that the user of druid has manually set. hats the usecase?
These methods are internally used by widgets to determine their behavior without explicitly repeating these info upon creating them. |
@RagibHasin yes, that part was obvious. =) I was hoping for a couple actual usecases for these. resize for example I'd probably just react to lifecycle size events. and I'm struggling to come up with a usecase for is_transparent that isn't resolved just by setting the background of a widget to transparent. not a big deal, primarily just curious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for letting this wait so long.
Please do the following:
- Rebase on
master
to resolve merge conflicts - Add a changelog entry to
CHANGELOG.md
Once we pass the CI I will take a deeper look.
6a66957
to
15b2f82
Compare
Sorry for the late response myself. Have been busy with coursework. However, should I see if this patch is also suitable for glazier and make a PR there? |
Alright we'll let this sit a bit more then, as I am very busy with 0.8 work as it is. The code changes are simple and would be a fast review, but the concerns of purpose brought up by @james-lawrence would need deeper thinking, which I'll postpone right now. Regarding sticking with this PR here or making one for Glazier - it really comes down to what you yourself want. Glazier is without a doubt the future of |
Add 3 methods to
WindowHandle
for querying if the window:At this moment only Windows and GTK+ backends are implemented and only Windows backend is tested locally.
I am not familiar with any backend except Windows so I don't see myself implementing these for the other backends.
These functionalities, especially transparency testing, are necessary for proper acrylic and mica background support on Windows through widgets.
Also, I anticipate that it would be also necessary for macOS translucent background if somebody implements it sometime.