Making move_to less strict. #320
Merged
+23
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @platlas sorry no-one has commented on your PR. There will be movement soon - it has been discussed on Zulip. It's bad DX when no-one responds to a contribution and I apologise for this. |
dfrg
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Thanks for the fix! I had concerns about the Segments iterator but based on your test case in this zulip comment it appears to be working correctly and I think I'm misremembering a change that did not happen.
There is an open question about how Segments should treat a path that does not start with a move element, but that is not relevant to this PR.
This all looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #303.