Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get as close as possible to full no_std support #160

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

mwcampbell
Copy link
Contributor

To really get no-std support in parley, we need to land dfrg/swash#63. But I believe I've done everything else that's necessary, in both parley and fontique. One can test the build by patching Cargo.toml to use the working branch for that swash PR, and modifying parley/Cargo.toml to specify swash/std or swash/libm as appropriate. If we decide to land dfrg/swash#63 before landing this one, then I can make the latter modification to parley/Cargo.toml before merging this PR.

Some of my changes, e.g. unconditionally using alloc::vec::Vec, are designed to minimize the amount of noise when searching the whole source tree for "std".

@mwcampbell
Copy link
Contributor Author

I saw @xorgy's approval. The only reason I'm not merging this immediately is that I wonder if we should land dfrg/swash#63 first, and publish a new version of swash (presumably a semver-breaking release), so we can go all the way with this PR. If people think it would be better to merge this PR immediately, that's fine.

@waywardmonkeys
Copy link
Contributor

dfrg/swash#63 and dfrg/swash#61 have both landed now. I have submitted a couple of additional PRs for swash and I don't know what his plans are for doing a new release.

@xStrom
Copy link
Member

xStrom commented Nov 7, 2024

I think it's fine to land this and when swash gets released do those steps in a separate PR.

Merged PRs are better than lingering PRs. When work can be split, it should. Helps reduce merge conflicts for yourself and others. Keeps the ball rolling.

@mwcampbell mwcampbell added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 824b9ba Nov 7, 2024
20 checks passed
@mwcampbell mwcampbell deleted the full-no-std branch November 7, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants