-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document most items in Masonry #815
Conversation
Move `#[allow(missing_docs)]` to dow modules. Missing docs now warn everywhere else by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement to the documentation. I have a few minor comments.
(For transparency, I'll mention I made heavier user of Copilot than usual for this PR. I don't think it's wrong, but I should probably have signaled this right away, and planned to do my own code review a day after, otherwise it starts to feel like I'm doing a high noise-to-signal contribution and expecting reviewers to filter the mistakes.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement. I don't see any issues.
Move
#[allow(missing_docs)]
to two modules. Missing docs now warn everywhere else by default.Remove
#[expect(rustdoc::broken_intra_doc_links)]
and fix all broken links.