Rename modules to follow new convention #843
Conversation
Rename module files from `foobar/mod.rs` to `foobar/_foobar.rs`. The full name is for readability when multiple module files are open in a text editor. The leading underscore is so these names appear first in file hierarchies.
|
There should probably be an open debate as to whether we adopt this convention. The upsides are as listed in the commit message. |
There was a problem hiding this comment.
I strongly object to this - we should not break from idiomatic Rust without very good reason.
I'm happy to be overruled if there's strong consensus in the other direction, especially if this is to be localised to Masonry.
I understand that you use an editor which is derivative of the VScode project, and so would suggest you use the Customise Tab Labels feature for this purpose. I have a rule set up which does this for me (not to hand)
Certainly I can see the appeal of sorting the mod.rs file first. I imagine there are already upstream issues tracking this in Rust Analyzer - I know that vscode has some neat tricks around file organisation contributed by extensions
It doesn't, actually: microsoft/vscode#27286 In any case, I'm not going to push for this if there's strong objection. |
This comment has been minimized.
This comment has been minimized.
Rename module files from
foobar/mod.rstofoobar/_foobar.rs.The full name is for readability when multiple module files are open in a text editor. The leading underscore is so these names appear first in file hierarchies.