Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Masonry modules #848

Merged
merged 15 commits into from
Jan 24, 2025
Merged

Reorganize Masonry modules #848

merged 15 commits into from
Jan 24, 2025

Conversation

PoignardAzur
Copy link
Contributor

No description provided.

@PoignardAzur
Copy link
Contributor Author

First commit just moves modules around and adds temporary re-exports in lib.rs to avoid changing too many files.

@PoignardAzur
Copy link
Contributor Author

This PR was executed in roughly four steps:

  • Run cargo +nightly fmt with imports_granularity = "Item"
  • Move items, files and modules around to get the desired structure.
  • Use a lot of sed commands to bulk-change import directives to point to the right modules.
  • Run cargo +nightly fmt with imports_granularity = "Module" to restore the previous structure.

In theory there shouldn't be any code changes, though in practice I can't guarantee it.

@PoignardAzur PoignardAzur marked this pull request as ready for review January 23, 2025 14:51
PoignardAzur added a commit that referenced this pull request Jan 23, 2025
Note: some of the doc depends on #832 and #848 which haven't been merged yet.
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to approve this design, I don't see any issues. Daniel suggested splitting a few things up, so it's worth considering that, too.

@PoignardAzur PoignardAzur added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit d77b31b Jan 24, 2025
18 checks passed
@PoignardAzur PoignardAzur deleted the reorganize_modules branch January 24, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants