-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a button view+widget with up to 9 labels #866
Open
eugenesvk
wants to merge
30
commits into
linebender:main
Choose a base branch
from
eugenesvk:fr-button9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visualize the logic of interlappin pads better
7ede4f3
to
27f3e55
Compare
b9af9d6
to
e531a29
Compare
This feels like the kind of case where we might want a "widget nursery" kind of crate, like druid had. It wouldn't need to be a separate repository, though, I don't think that separation was really useful. |
What do you think of just making the default widgets overpowered and add all the extra functionality like this to them? |
I'm a bit iffy on that. The complexity quickly adds up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the creation of helpful UI buttons like this, documenting which keys activate it

It supports label padding as well, so you could in principle position labels wherever you like
I've noticed that even empty labels have >0 size (4) and, I guess, makes the button slightly bigger than necessary. Is this an effect of some global layout constant?
My idea is for this to be identical in its default instance to a regular button.
I've also thought about skipping empty children (though currently it's suprisingy cumbersome to test whether a label is empty, so thought of adding some
is
method to the label to check whether its string is empty), but then wasn't clear on the proper mechanism for instantiating such children once their text is changed, so thought it might not be an issue if empty labels always exist.Updated docs/tests and added a
gallery
type example similar to #864