Separate faucet functionality into linera-faucet crate
#3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
faucet
branch
2 times, most recently
from
3051632 to
d9a944a
Compare
afck
approved these changes
Feb 6, 2025
linera-faucet/server/Cargo.toml
Outdated
| @@ -0,0 +1,29 @@ | |||
| [package] | |||
| name = "linera-faucet-server" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Not sure if this should follow the workspace version (version.workspace = true) instead?
There was a problem hiding this comment.
It definitely should, thank you :)
Move the faucet client and server from `linera-service` into new
crates, `linera-faucet-{client,server}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to be able to create wallets from the Web. Our current preferred flow for creating wallets involves contacting the faucet for the desired network, but the faucet is currently only available within
linera-service.Proposal
Create new crates with client and server for the faucet, on which
linera-serviceandlinera-webboth depend.Test Plan
Refactor: handled by existing tests.
Release Plan
Links