feat(vite-plugin): add error handling for dynamic import of @lingui/macro #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acro This commit adds error handling for dynamically importing the @lingui/macro module in the vite-plugin. When the @lingui/macro module is dynamically imported, an error is thrown with a helpful message guiding the user to check their import statement and providing a link to the documentation for configuring Vite with Lingui correctly. Closes lingui#2050
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
|
LGTM, thanks for contribution |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
- Coverage 76.65% 75.45% -1.20%
==========================================
Files 81 89 +8
Lines 2090 2176 +86
Branches 533 552 +19
==========================================
+ Hits 1602 1642 +40
- Misses 375 423 +48
+ Partials 113 111 -2 ☔ View full report in Codecov by Sentry. |
|
@maastrich are you going to add something to this PR or you finished? We are preparing v5 release and it would be better to switch it to the |
|
Hi @maastrich, is there anything we can do to move this PR forward? |
| @@ -33,6 +33,16 @@ export function lingui(linguiConfig: LinguiConfigOpts = {}): Plugin[] { | |||
| ) | |||
| } | |||
| }, | |||
| resolveDynamicImport(specifier, importer, options) { | |||
| if (specifier === "@lingui/macro") { | |||
There was a problem hiding this comment.
in v5 it should check for @lingui/macro and @lingui/react/macro and @lingui/core/macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure the user understands why
@lingui/macrois not handled by babel/swc when dynamically imported.Types of changes
Checklist