[fast-avro] Schema evolution: complex fields changed to nullable #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #538 +/- ##
============================================
- Coverage 46.12% 46.11% -0.02%
+ Complexity 4540 4536 -4
============================================
Files 407 407
Lines 28423 28423
Branches 4637 4637
============================================
- Hits 13110 13106 -4
Misses 13746 13746
- Partials 1567 1571 +4 ☔ View full report in Codecov by Sentry. |
|
Hey @krisso-rtb, thanks for the fix! Do you know any history about when this bug was introduced? |
|
Hi @dg-builder, It looks like the issue was added more than 1 year ago as part of: |
… nullable. Scenario: Record is serialized using schema with not-null complex fields (record, map, array) and later deserialized with changed schema having these fields nullable (union of "null" complex type).
krisso-rtb
force-pushed
the
fast-avro-record-changed-to-nullable-record
branch
from
0c53b89 to
5a6b1a6
Compare
dg-builder
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fast-avro] Fixing case when schema changed and complex fields became nullable.
Scenario: Record is serialized using schema with not-null complex fields (record, map, array)
and later deserialized with changed schema having these fields nullable (union of "null" complex type).