Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add for utf8 method in String/Utf8/Charsequence ListViews #558

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add for utf8 method in String/Utf8/Charsequence ListViews #558

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c58c07
Adding add for utf8 and equals methods in String/Utf8/Charsequence Li…
li-ukumar Jun 25, 2024
2d2e6bb
removing unecessary equals method
li-ukumar Jun 25, 2024
04c3ec5
AddAll methods for List/Set
li-ukumar Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .../main/java/com/linkedin/avroutil1/compatibility/collectiontransformer/StringListView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,30 @@ public String set(int index, String element) {
return previousValue;
}

public String set(int index, Utf8 element) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add this method in base class/interface?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base class is java's AbstractList. We cant modify that

String previousValue = String.valueOf(_utf8List.get(index));
_utf8List.set(index, element);
return previousValue;
}

@Override
public void add(int index, String element) {
_utf8List.add(index, new Utf8(element));
}

public void add(int index, Utf8 element) {
_utf8List.add(index, element);
}

Comment on lines +52 to +55
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no such method in the base class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Base class only has methods for String in this case.. (Since we are extending AbstractList).

@Override
public boolean add(String element) {
return _utf8List.add(new Utf8(element));
}

public boolean add(Utf8 element) {
return _utf8List.add(element);
}

@Override
public boolean addAll(int index, java.util.Collection<? extends String> c) {
boolean modified = false;
Expand All @@ -58,6 +72,30 @@ public boolean addAll(int index, java.util.Collection<? extends String> c) {
return modified;
}

/**
* Overloaded method to add all Utf8 elements of a collection at a specific index.
*/
public boolean addAll(int index, java.util.List<? extends Utf8> c) {
boolean modified = false;
for (Utf8 element : c) {
_utf8List.add(index++, element);
modified = true;
}
return modified;
}

/**
* Overloaded method to add all Utf8 elements of a set at a specific index.
*/
public boolean addAll(int index, java.util.Set<? extends Utf8> c) {
boolean modified = false;
for (Utf8 element : c) {
_utf8List.add(index++, element);
modified = true;
}
return modified;
}

@Override
public boolean remove(Object o) {
return _utf8List.remove(new Utf8(o.toString()));
Expand Down
Loading