Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add replication throttle config to rebalance/add/remove/demote options #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

countableSet
Copy link

@countableSet countableSet commented Jan 21, 2025

adds replication throttle configuration to configuration options for rebalance, add, remove, and demote broker

plus move around ui for demote to fit the new input box better
fix bug with demote broker where concurrent_leader_movements wasn't being set

cc #126

Screenshot 2025-01-21 at 11 44 15 Screenshot 2025-01-22 at 13 45 41

other fixes

  • dev server wouldn't start without adding require path (node version v18.16.1)
❯ npm run dev

> [email protected] dev
> test -d cruise-control-ui && cd cruise-control-ui; node build/dev-server.js

/Users/countableset/code/countableset/cruise-control-ui/build/webpack.dev.conf.js:33
      favicon: path.resolve(__dirname, '../src/assets/images/cc-favicon.png'),
               ^

ReferenceError: path is not defined
    at Object.<anonymous> (/Users/countableset/code/countableset/cruise-control-ui/build/webpack.dev.conf.js:33:16)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/Users/countableset/code/countableset/cruise-control-ui/build/dev-server.js:15:21)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47

Node.js v18.16.1
  • localhost:8090/static/config.csv would 404 in dev server, changed express config to app.use(/${staticPath}, express.static(path.join(__dirname, '../static')))

@countableSet countableSet changed the title add replication throttle config to rebalance options add replication throttle config to rebalance/add/remove/demote options Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants