Use OutputFile.location to track metadata JSON files (#566)

linkedin · Oct 21, 2019 · 3bc1946 · 3bc1946
1 parent 798ba1f
commit 3bc1946
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java b/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
@@ -120,7 +120,7 @@ protected String writeNewMetadata(TableMetadata metadata, int newVersion) {
     // always unique because it includes a UUID.
     TableMetadataParser.overwrite(metadata, newMetadataLocation);
 
-    return newTableMetadataFilePath;
+    return newMetadataLocation.location();
   }
 
   protected void refreshFromMetadataLocation(String newLocation) {

diff --git a/hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java b/hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java
@@ -19,6 +19,7 @@
 
 package org.apache.iceberg.hive;
 
+import com.google.common.collect.Iterables;
 import com.google.common.collect.Maps;
 import java.io.IOException;
 import org.apache.iceberg.AppendFiles;
@@ -279,4 +280,27 @@ public void testCreateOrReplaceTableTxnTableCreatedConcurrently() {
     Assert.assertEquals("Partition spec should match", PartitionSpec.unpartitioned(), table.spec());
     Assert.assertEquals("Table props should match", "value", table.properties().get("prop"));
   }
+
+  @Test
+  public void testCreateTableTxnWithGlobalTableLocation() {
+    Assert.assertFalse("Table should not exist", catalog.tableExists(TABLE_IDENTIFIER));
+
+    Transaction txn = catalog.newCreateTableTransaction(
+        TABLE_IDENTIFIER, SCHEMA, SPEC, "file:///" + tableLocation, Maps.newHashMap());
+    txn.commitTransaction();
+
+    Table table = catalog.loadTable(TABLE_IDENTIFIER);
+
+    DataFile dataFile = DataFiles.builder(SPEC)
+        .withPath("/path/to/data-a.parquet")
+        .withFileSizeInBytes(0)
+        .withRecordCount(1)
+        .build();
+
+    table.newAppend()
+        .appendFile(dataFile)
+        .commit();
+
+    Assert.assertEquals("Write should succeed", 1, Iterables.size(table.snapshots()));
+  }
 }