fix: notifier state get's never persisted in database #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegocepedaw
requested changes
Jun 2, 2022
src/oncall/notifier/reminder.py
Outdated
| window_start) | ||
| # create a clean state in the datebase | ||
| cursor.execute('TRUNCATE `notifier_state`') |
There was a problem hiding this comment.
Fix Flake8 errors and make sure circleci tests are passing
src/oncall/notifier/reminder.py:54:52: W291 trailing whitespace
jrgp
requested changes
Jun 2, 2022
roock
force-pushed
the
rp_fix_notifier_state
branch
from
39152bd to
7eaa049
Compare
- ever time the notification starts, it reports a corrupted state because the state never gets stored in the databse. saving the state in the database using `UPDATE` sql only works when there is already one entry in the table, otherwise the query will run through with zero updated rows. so in the case when the state cannot be loaded, we properly create one record inside the notifier_state table
roock
force-pushed
the
rp_fix_notifier_state
branch
from
7eaa049 to
2993b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because the state never gets stored in the database.
saving the state in the database using
UPDATEsql only workswhen there is already one entry in the table, otherwise the query
will run through with zero updated rows.
so in the case when the state cannot be loaded, we properly create
one record inside the notifier_state table