build(rustls): Upgrade tokio-rustls to 0.26 #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)"" This reverts commit de25333.
olix0r
reviewed
Jan 22, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3557 +/- ##
==========================================
- Coverage 67.68% 66.79% -0.89%
==========================================
Files 332 388 +56
Lines 15158 18157 +2999
==========================================
+ Hits 10259 12128 +1869
- Misses 4899 6029 +1130
... and 170 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
During the rustls upgrade, it accidentally limited the set of supported signature algorithms to ECDSA256 signatures. This would cause the identity control plane proxy to reject all certify requests with BadSignature if an RSA certificate was used instead of ECDSA. This updates the set of supported algorithms to most of the full set of what rustls+ring supports, minus a few legacy algorithms. Tested by deploying to a local cluster and verifying the control plane comes up correctly and app-level networking works as expected. Signed-off-by: Scott Fleener <[email protected]>
olix0r
approved these changes
Jan 22, 2025
|
Before merging, I suggest you manually test this proxy version against the linkerd2 bin/tests... |
Yep, tested it locally and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a retry of #3419, which was reverted by #3553.
This includes a fix that caused the control plane to never be ready due to a reduction in the set of supported signature algorithms. See 01e0782 for details.