Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(multicluster): increase federated test timeout #13393

Merged
merged 1 commit into from
Nov 25, 2024
Merged

ci(multicluster): increase federated test timeout #13393

merged 1 commit into from
Nov 25, 2024
+1 −1

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Nov 25, 2024

The one minute timeout is too conservative in GitHub Actions. This change bumps it to 3 minutes.

@olix0r
ci(multicluster): increase federated test timeout
be5e583 
The one minute timeout is too conservative in GitHub Actions. This
change bumps it to 3 minutes.
@olix0r olix0r requested a review from a team as a code owner November 25, 2024 16:51
@olix0r olix0r enabled auto-merge (squash) November 25, 2024 16:54
adleong
adleong approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several one minute timeouts throughout this test and the other multicluster integration test which this test is modeled after. Should we bump them all to 3 minutes?

@olix0r olix0r merged commit 8565694 into main Nov 25, 2024
40 checks passed
@olix0r olix0r deleted the ver/federated-test-timeout branch November 25, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adleong adleong adleong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olix0r @adleong