Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Flynn <[email protected]>
  • Loading branch information
zaharidichev and kflynn authored Dec 4, 2024
1 parent 487ddb9 commit a607121
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion linkerd.io/content/2-edge/reference/egress-network.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: EgressNetwork

Linkerd's [egress functionality]({{< relref "../features/egress">}}) allows
you to monitor and control traffic that leaves the cluster. This behavior is
controller by creating `EgressNetwork` resources, which describe the properties
controlled by creating `EgressNetwork` resources, which describe the properties
of traffic that leaves a cluster and provide a way to apply policies to it, using
Gateway API primitives.

Expand Down
6 changes: 3 additions & 3 deletions linkerd.io/content/2-edge/tasks/managing-egress-traffic.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ outbound_http_route_request_statuses_total{
} 697
```

Notice that these raw metrics allow to quickly identify egress traffic targeted
Notice that these raw metrics allow you to quickly identify egress traffic targeted
towards different destinations simply by querying for `parent_kind` of type
`EgressNetwork`. For now all traffic is allowed and we are simply observing it.
We can also observe that because our `EgressNetwork` default traffic policy is
Expand Down Expand Up @@ -124,7 +124,7 @@ outbound_http_route_request_statuses_total{
```

We can clearly observe now that the traffic targets the same parent but the
name of the route is not `http-egress-deny`. Furthermore, the `http_status` is
name of the route is now `http-egress-deny`. Furthermore, the `http_status` is
`403` or `Forbidden`. By changing the traffic policy to `Deny`, we have forbidden
all egress traffic originating from the local namespace. In order to allow some
of it, we can make use of the Gateway API types. Assume that you want to
Expand Down Expand Up @@ -274,7 +274,7 @@ following rules:
- all other unencrypted HTTP traffic need to be redirected to an
internal service

To begin with, lets create our internal service to which traffic should be
To begin with, let's create our internal service to which traffic should be
redirected:

```bash
Expand Down

0 comments on commit a607121

Please sign in to comment.