Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing \ #1857

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add missing \ #1857

merged 1 commit into from
Oct 22, 2024

Conversation

GTRekter
Copy link
Contributor 

linkerd jaeger install
  --set webhook.externalSecret=true \
  --set-file webhook.caBundle=ca.crt \
  | kubectl apply -f -

this command is missing a \ at the end of the first line.

@GTRekter GTRekter mentioned this pull request Oct 22, 2024
Closed
@wmorgan
Copy link
Member

wmorgan commented Oct 22, 2024

Note to mergers: DCO check can be skipped here

@kflynn
Copy link
Member

kflynn commented Oct 22, 2024

Forcing DCO because a) @wmorgan is right and b) @GTRekter is an employee anyway. 🙂

kflynn
kflynn approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GTRekter! 🙂

@kflynn kflynn merged commit db10727 into linkerd:main Oct 22, 2024
7 checks passed
@GTRekter GTRekter deleted the bug/1856 branch October 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflynn kflynn kflynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GTRekter @wmorgan @kflynn